Most notable for testing is that I made some big changes around the WebSocket management. I’ve been running locally and haven’t had any problems, but I’m really looking for anyone that can test and let me know if there’s any noticeable problems with it keeping the websocket open, or if there are any visible changes to the way it deals with reconnects, etc.
When it disconnects because you connected somewhere else, it now shows this message: Already connected from another session
That’s different than what it used to display and not actually what happened. It seems to functionally work ok.
Ah, but I do see some nice changes:
Getting rid of the useless “Information” tab. Although, I feel like if that was redesigned so everything was much larger, it could be a useful view.
Overall Full Screen
WiFi Settings - The only potential issue I see (I didn’t test this), is that if you choose to display the password, it’s all asterisks since FluidNC won’t provide that info. I’m curious if that could inadvertently change the password to asterisks. I suppose each piece of information is a separate command so it’s probably ok.
And it looks like you fixed this in the last release, but I didn’t notice until now, it now shows the hostname instead of I think it used to say undefined.
I did notice that. I think the new websocket code toasts every error it comes across right now. I probably need to be more selective. It’s also got a bunch of debug stuff still in the console log I think that I need to remove
I thought this was going to be a better idea, but it turns out it doesn’t work on most devices because of limitations they impose.
I wanted it for my iPad because it’s such a pain to enter fullscreen, but the button does nothing. So for now, it hides itself on incompatible devices.
Feels like that might be a moving target though, and the only place it will be available is where it’s already easy to go fullscreen.
I was thinking instead it might be better to move the Quick Stop button there
I think you could move the hamburger and quick stop button and still keep the fullscreen button. I display a logo there in my themes, but that was only because it was empty space. I’d rather have useable space than fill it with a logo. I don’t think the fullscreen button needs a label regardless of screen size. That is also consistent with the panel fullscreen buttons.
Doing a little testing of this on 4.0.0-pre1. Every time I go from the Settings tab back to the Dashboard tab, it outputs all this info in the terminal.
There’s something wrong with extensions in 3.0.0.6 that works fine with 3.0.0.5. It seems like the way that extensions get data isn’t working. Maybe? Although I am seeing an error about preferences.json in the upper right:
It’s successfully sending commands from an extension but the extension doesn’t seem to be getting any responses.
I definitely made some changes in the websocket code, and that ties into the dispatchToExtensions, etc.
not sure about preferences.json. I didn’t have any problems with that, but the entire web server got switched out in this version and I haven’t tried running on v4 firmware yet. I can’t get my S3 to flash