After being stumped for awhile, I think I fixed it. I need to do some more testing before I submit a PR.
(For anyone poking around here, Mike’s fork is the official FluidNC one. Mine is a fork of Mike’s just so I can make some changes and create a PR.)
Here’s what I changed. @Michael_Melancon Feel free to veto some of these changes. I did a couple things like my themes which I don’t know if that’s ok. My custom things can be removed/altered but I think they are reasonable enhancements. I hope to change my themes to just be color changes, logos, and maybe minor formatting. While it was fun at the time, I’m concerned about maintaining them when they go beyond that.
There was a previous change to handle expanding the jog panel when extra axes were used. I undid that and changed it so that it can shrink (which it did before) and not interfere with extensions. But it goes further, more similar to how my theme works. Most panels are fine to shrink all the way to the content, except I gave the terminal a 300px minimum height.
I changed the formatting of the macros to be like my theme. The button were unorganized and too close together to use conveniently from a touch device.
Fixed the extension formatting issue where it wasn’t using the full width and not resizing properly. Also, it had issues when loading the page. If a panel like the Jog panel was above extensions, when it picked up the config, it resized and overlayed the extension panels. This took awhile to figure out.
That was definitely the goal as we were trying to get this soaked in as part of the official repo, but I’m not quite as concerned as I was before.
I still try to keep it close for merging sake, but I think I read somewhere that Luc is already pushing new things to a v4, so I think we are safe for almost anything at this point
Ok, sounds good. I have another minor change so the extension panels don’t use the full size needed for the jog panel with XYZABC axes enabled unless it needs to.
I have a bit more testing to do but it’s looking good. There are a couple other minor issues I want to look at like sometimes the Status panel has an unnecessary horizontal scrollbar and I can’t see the very bottom of the bottom panel on my phone. I don’t think these are anything new though.
I also increased the panel margin a bit as a workaround to not being able to scroll over extensions because they’re in an iframe.
Back in January I had started extending it so that when you upload a file over wifi it would verify the file hash as it existed on the server to make sure it made it all there correctly…
Web development is sooo duuummmbbb sometimes. It turns out it’s treating 100vh as the height of the viewport assuming the URL bar is hidden. Changing 100vh to 100% resolves that issue but breaks the buttons always displaying without having to scroll to the bottom on the Settings tab.
Well, I finally got back to this. I think I’m done making changes.
This includes the following changes in addition to what I posted above:
Extension panels don’t use the full size needed for the jog panel with XYZABC axes enabled unless it needs to.
Removed unnecessary horizontal scrollbars on status panel and information tab
Fixed issue with being unable to see the very bottom of the bottom panel and the bottom buttons on my phone (change 100vh to 100dvh)
Added configuration option for default distance for the jogging panel. This has been suggested by a couple people now since accidentally jogging with a default of 100 can be problematic. It leaves 100 as the default.
Note I’m not currently using any of my themes. I have some changes in progress where I’m basically removing most formatting and leaving it be mostly just color changes. Currently, my themes do not work as intended.
At least for what I changed, it doesn’t matter. I did recently update to 3.9.7. I only ran one job with it so far and it stayed at 99.something% complete even when it was finished. I didn’t investigate. That could be completely unrelated.
I don’t have time to actually test any of it currently, but when everyone is happy that it’s ready to go, I can merge it in and get the latest version built and placed into the web installer
Trying not to hijack this thread but want to mention this in case it is relevant. I upgraded from 3.9.4 to 3.9.7 and the UI became very sluggish to the point of becoming unresponsive if left on overnight. I tried this WebUI as well as WebUI 3.0.0-4b1, 3.0.0-4a1, and 3.0.0-a81.F2 - all with the same result. I then downgraded to 3.9.6, 3.9.5 and finally back to 3.9.4 to get stable again. 3.9.5 may have been OK but 3.9.6 and 3.9.7 both caused the Web UI to become sluggish for me.
I’m now running the UI above with 3.9.4 and all is good.
Hmm, that’s interesting. In general, I wouldn’t leave it on overnight and if I accidentally did, I would power cycle before using. However, one of the test cuts I ran a couple days ago on 3.9.7 resulted in low memory warnings which I haven’t seen in a long time. I ran that a couple times but only saw the warnings once.
Prior to this, on my Lowrider, I was running 3.9.2-pre1 without issues. I’ve been using 3.9.4 on a Jackpot on my pen plotter without issues. I do have 3.9.6 on an eggbot. I don’t remember having issues there but I was more focused on the physical side of that. That’s also on a 2 axis pen/laser board. For that I also ran the WebUI for that from my PC where otherwise I run jobs from my phone. With my phone, it goes to sleep and has to reconnect to the WebUI.
Thanks for that feedback. It certainly warrants some more investigation.
So far both are doing normal. If I check a lot heap seems to go down, but I left it alone for 20 minutes and heap went back up, min is not really moving.
