Forking discussion for progressing LR4 Calculator
Testing fix for unexpected default page load behavior showing yuge values. Sending pull request shortly…
Fixing minor annoying script error too…
Created Update calculator.md fix default load values by aaronse · Pull Request #550 · V1EngineeringInc/V1EngineeringInc-Docs · GitHub, haven’t looked at this page for a while. There’s probably other should-fix/nice-to-fix stuff. Would like to just address must-fix issues like wrong dimensions for now though.
@orob, am trying to grok your observations, there something else we must fix?
You might have fixed it. I am not sure. I am a little brain fried I have to look again tomorrow. Thank you! Thank you!
2 Likes
Take a well deserved break and have a well deserved beer!
4 Likes
situation: user inputs overall max cut width for X.
Calculator caclulates tube length and overall table x dimension.
The calculation of X dimension when user inputs cut width is too large. For my calculation, it should have been 45 and came out as 56.75. I’m unsure of the math used for that calculation, it could have been the wrong conversion factor or an offset. I don’t know which.
What’s your Usable Cut X in inches or mm, 33.632", 854mm or something else? Am trying to confirm what Usable X you think should result in 1022mm X pipe and 45" X foot print.
Here’s what I expected…
Here’s what I actually see…
The LR4 Calculator web page is definitely doing some rounding to closest 0.25", and we potentially lose some smaller fraction of an inch if we flip between units for certain values (not a big deal imo).
Am not seeing/understanding the unexpected behavior you’re observing though?
1 Like
Your numbers look like mine. I rounded a little, so I wasn’t terribly concerned about the 0.25 on the 40". it is the table width that should be 45" and not 56.25" that is the major issue.
I just ran it again to take a screenshot and it is not showing 56 anymore, so it appears to be repaired.
Where are you seeing 56.25", I don’t see that? Table Size shows as 45". Full disclosure, I just had a Guinness.
2 Likes
The LR4 calculator is a copy of the 3. Its always done it, but everyone just kinda lived with it because the numbers came out close enough 
I’m away from my computer (4am here…), but it’s a relatively easy fix.
At the time, I was waiting til closer to release to ask Ryan what he wanted to do about it, but now I’m out of town when the release actually happened.
I think the idea was to keep it from showing ridiculous conversion numbers like mm to the 10th decimal place, but it probably just needs a better display format string or something rather than changing the value.
2 Likes
1 Like
That probably fixed it.
3 Likes
Great, am able to repro (on v1e.com but not my local machine) :
- browse to LowRider V4 Calculator - V1 Engineering Documentation
- click “Inch” unit
- Edit Usable Cutting Area X to 33.632 and hit enter or tab.
- Expected: Table Size length 45"
- Actual: Table Size length 57"
1 Like
Obligatory XKCD.
3 Likes
but if you then press the reset button and enter 33.6, it shows 45" table size and the tube length goes from 40 to 40.25"
1 Like
Will submit separate pull request proposing a way to reduce these conversion resolution based inconsistencies. Could use 0.05" (1/20") resolution instead of 1/4" (0.25"), well almost…
2 Likes
honestly, I feel like any “clipping”/“rounding” of the numbers, should be display only.
Otherwise, you’ll never be able to round trip your entry between in and mm
4 Likes
agree. Prefer the calculation to be done with as much precision as possible then adjust the final number only.
2 Likes
Inches should be rounded to the nearest .001" or 0.0001"? Since an 1/8" is still pretty coarse and it is 0.125".
That calc was made for lr1 sizes did not matter nearly as much.
I say give way more precision now. 1mm is very doable, that is 0.04" so at least that much.
3 Likes
IIRC, the rounding was to make the combo boxes work better. But it might have been so the conversion didn’t drop a ton of digits on you.
FWIW, this was written in about an hour originally and has lasted much longer than it should have without being refactored and done properly.
4 Likes
It lasted 3 LR versions, That was a valuable hour!!!
4 Likes