Ryan:
It is not private is it?
no
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
You need to create a secret and put your token in it.
You just need to replace it in the yaml.
You can’t call it GITHUB_TOKEN though.
So if you create one called ‘REMOTE_TOKEN’
it would be replaced like this instead
env:
GITHUB_TOKEN: ${{ secrets.REMOTE_TOKEN}}
1 Like
ahh…
then scratch all that lol
built-in is better than self-created if it works
2 Likes
but you still need to put that in the action file
to define the environment variable when it runs the build command
3 Likes
vicious1
(Ryan)
December 11, 2024, 7:33pm
24
So maybe I add that as a second one
Then I can make the token and give it the secret permissions?
1 Like
adding a second will either fail, or just overwrite the first
2 Likes
vicious1
(Ryan)
December 11, 2024, 7:37pm
27
contributors · V1EngineeringInc/V1EngineeringInc-Docs@1b438c3 · GitHub , Nope same error. I think I need to make a new token, not use the automatic githubtoken
1 Like
You may have exceeded the API rate limit or need to be authorized. You can set a token under 'token' mkdocs.yml config or MKDOCS_GIT_COMMITTERS_APIKEY environment variable.
Add another environment variable
env:
MKDOCS_GIT_COMMITTERS_APIKEY: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN : ${{ secrets.GITHUB_TOKEN }}
3 Likes
vicious1
(Ryan)
December 11, 2024, 7:38pm
29
to both build and deploy?
1 Like
whichever workflow is doing the mkdocs build that has the plugin fetching
2 Likes
ok… i see.
you have it in deploy.yml, but it should be in build.yml
that’s where the requests are actually happening, during mkdocs build
1 Like
vicious1
(Ryan)
December 11, 2024, 7:42pm
32
It needs it in deploy as well to be able to write I think.
1 Like
Missing ‘$’ in front of the expression
3 Likes
Ryan:
It needs it in deploy
it won’t hurt it to be there, but I don’t think you need it now, if you didn’t before
1 Like
vicious1
(Ryan)
December 11, 2024, 7:45pm
36
looks like it is working!!!
3 Likes
vicious1
(Ryan)
December 11, 2024, 7:47pm
38
So now I can edit the docs landing page to remove the contributors section and they will be more easily seen where they put in the work!
2 Likes
vicious1
(Ryan)
December 11, 2024, 7:50pm
39
So I need to pack some orders but the stretch goal here is to start using the insiders edition for a few other special features.
2 Likes
Ryan:
insiders edition
hmm… I’ve never heard of it. Is that a MkDocs thing?
If that’s a premium/paid thing, does that affect who can contribute, or how contributions are made?
1 Like